Selecting InlineShapes

[Derek]

Hi,

I'm trying to loop through all the inlineshapes in a MS Word 2010
document and convert them to jpg (to make the file size smaller).
However, when I try to select the inlineshape, it is always the first
inlineshape that is selected. It never moves to the next inlineshape.
Also, the macro never finishes...

Thanks,
Derek

Sub PasteAsJPEG()
'
' Cut each picture and paste it back in as a JPEG
'
Dim Pic As InlineShape

For Each Pic In ActiveDocument.InlineShapes
Pic.Select
With Selection
.Cut
.PasteSpecial DataType:=15
End With
Next Pic
End Sub

 

[Jay Freedman]

This is a general problem: When you cut or delete a member of a collection, behind your back VBA redoes the internal index of the collection that it uses to keep track of the For Each iterations. The
recommended way is to use an explicit index, and work from the end of the collection back to the beginning. Try it this way:

Sub PasteAsJPEG()
'
' Cut each picture and paste it back in as a JPEG
'
' Dim Pic As InlineShape
Dim i As Long

For i = ActiveDocument.InlineShapes.Count To 1 Step -1
ActiveDocument.InlineShapes(i).Select
With Selection
.Cut
.PasteSpecial DataType:=15
End With
Next i
End Sub

 

[Derek]

Thanks, works perfectly.